Skip to content

2.x fix build and deploy#7822

Merged
markstory merged 4 commits intocakephp:2.xfrom
tenkoma:2.x-update-dockerfile-and-build
Mar 17, 2024
Merged

2.x fix build and deploy#7822
markstory merged 4 commits intocakephp:2.xfrom
tenkoma:2.x-update-dockerfile-and-build

Conversation

@tenkoma
Copy link
Copy Markdown
Member

@tenkoma tenkoma commented Mar 17, 2024

Apply #7820 to 2.x branch.

Version 2.x document deployments are also broken, as is version 3.x.
I will fix it.

When I created a fix for the 3.x branch, it was successfully deployed. 🎉
Therefore, this time, I will try to do the merge without review.
Please review :)

@tenkoma tenkoma added this to the 2.x milestone Mar 17, 2024
@tenkoma tenkoma self-assigned this Mar 17, 2024
@tenkoma tenkoma marked this pull request as ready for review March 17, 2024 15:59
@tenkoma
Copy link
Copy Markdown
Member Author

tenkoma commented Mar 17, 2024

The build succeeded and is now merged.

@markstory markstory merged commit 307ee30 into cakephp:2.x Mar 17, 2024
@markstory
Copy link
Copy Markdown
Member

Thank you 🎉

@tenkoma tenkoma deleted the 2.x-update-dockerfile-and-build branch March 18, 2024 02:13
@tenkoma
Copy link
Copy Markdown
Member Author

tenkoma commented Mar 18, 2024

Deployment was also successful: https://github.com/cakephp/docs/actions/runs/8318367417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants